Death with a weapon in your hands. That's the rule. There was also a caveat that you had to be whole. If you lost a hand in battle but lived, you were no longer destined for Valhalla. You could still die a warriors death in your next battle and be welcomed in Odin's Hall, but not Valhalla.