I want to put some things into perspective as a founder of a small local gun rights org. There are a lot of things that NRA has to fix, but they are also doing a lot of things right.
Gun Right activism and lobbying is all about the membership numbers. You need enough people to affect the elections, provide donations, participate in activism, and a base to develop leaders from. NRA has supposedly 6 million members which can effectively do all of the above stuff.
You can't get those membership numbers just from lobbying/legal action(nraila) and political arm(nrapvf). SAF/CCRKBA have 650,000 gun rights advocate members in the two orgs, I would guess most belong to both so 450,000 members. A good amount but not enough to swing elections. The SAF and others do win important lawsuits, but to do so you need 2a friendly judges, who are appointed by politicians, who are elected, and whom you need a large 2a voting base to affect the elections.
The reason NRA has the numbers is they cater to a very diverse audience through AckMac. Hunters, first time shooters through education, youth safety, junior air rifle programs, law enforcement, military, competitive shooting, defensive carry, community activities, etc.
To get all of those groups you need a good marketing firm that hits all areas, all age groups, all races, and all income brackets. That's the reason for NRATV, Eddie eagle, friends of the NRA, etc. I think AckMac and Wayne did a good job at that
The problem lies with the accountability, transparency, conflicts of interest, and lavish spending.