Posted: 11/11/2009 3:23:29 PM EDT
| Question for any professional coders out there. Do you have a formal code review process? My team lead is implementing a process whereby everyone on the team may not check in a single line of code until it has been emailed to a 2nd developer and approved. I've been coding for 10 years, and in my experience there is only a review for new developers, and reviews are not used once a developer has gained some experience. Note that generally we're not coding mission critical software, just software tools and utilities. |
|
Quoted:
Emailing seems to be a weird way of doing it. Your versioning software should allow another dev to do a diff to see your changes. We use Subversion. If you could provide some details on Subversion-specific processes you're familiar with, it would be appreciated. |
|
if it actual code review = catch the dumb stuff, then the times i have used it it works great. but the times i was able to use it was rare. in my opinion, one needs reasonably competent developers who can check their egos for code review to work well, else it degrades into two retarded monkeys (programmers who can't program) arguing (can't check their ego) about who's God is the correct god (admit that their implementation sucks). edit: ideally you want to catch bad designs before they are coded....  |
|
Quoted:
Quoted:
Emailing seems to be a weird way of doing it. Your versioning software should allow another dev to do a diff to see your changes. We use Subversion. If you could provide some details on Subversion-specific processes you're familiar with, it would be appreciated. Depends on how you do things. If you create a new branch for each new feature you add (then merge into trunk when it's done) then it's easy to see the diff between the branch and trunk. Otherwise, you'll have to send your modified files to the other dev, who will drop them in a svn'd directory, then just svn diff locally to see the changes. |
| Thanks for the responses guys. Instead of being a complete obstinate ass at our department meeting today, I was only slightly obstinate. My concerns were characterized as "a good point". That point being, sometimes shit needs to get done ASAP and formal reviews will prevent that. So it was generally agreed that if the SHTF reviews can be done after checkin. |